Solution #1376
Solution #1376
Conversation
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 Your code meets all the task requirements effectively. While there are some suggestions for improvement, such as handling mutable arguments more robustly and ensuring the cache logic is clear, these don't detract from the functionality you've achieved. Keep up the good work and consider these enhancements for future projects! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
|
|
||
| def cache(func: Callable) -> Callable: | ||
| # Write your code here | ||
| pass | ||
| calculated_data = [] |
There was a problem hiding this comment.
The calculated_data variable should be a list of tuples, which it is, but it should be initialized as an empty list. This is correct, but ensure that the logic of storing and retrieving cached data is handled properly.
| def wrapper(*args, **kwargs) -> Any: | ||
| for value in args: | ||
| if isinstance(value, (list, set, dict)): | ||
| return None |
There was a problem hiding this comment.
Returning None when encountering a list, set, or dict in args might not be the best approach. Consider raising an exception or handling this case differently to avoid unexpected behavior.
No description provided.